Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode Spaces #104

Open
joshmedeski opened this issue Mar 1, 2024 · 1 comment
Open

Encode Spaces #104

joshmedeski opened this issue Mar 1, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@joshmedeski
Copy link

Describe the bug
I was trying to create a link that has a space in the URL

I expected all characters to be encoded into a valid URL

https://github.com/joshmedeski/dotfiles/blob/7a2f275e57d4a5e53da733bccfd8b2bca1928627/Library/Application%20Support/lazygit/config.yml#L85

The space was not encoded and created an invalid URL (See "Application Support" in URL below)

https://github.com/joshmedeski/dotfiles/blob/7a2f275e57d4a5e53da733bccfd8b2bca1928627/Library/Application Support/lazygit/config.yml#L85

To Reproduce

Generate a link that points to a directory that includes a space.

Expected behavior
Encode the URL values before copying it to the clipboard.

System (please complete the following information):

  • OS: macOS
  • neovim --version v0.9.5
  • git --version git version 2.39.3 (Apple Git-145)
@joshmedeski joshmedeski added the bug Something isn't working label Mar 1, 2024
@linrongbin16
Copy link

linrongbin16 commented Mar 10, 2024

hi @joshmedeski , let's discuss this issue at: linrongbin16/gitlinker.nvim#224.

Also see: #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants