-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rotated keys are displayed incorrectly when board is flipped. #64
Comments
I'm not sure if this is helpful but it looks to me like the keys are rotating around an incorrect point. KLE's method for that is confusing at best |
The obvious workaround in my case would be to print the mirrored image but where's the fun in that? I believe that the way to get this displayed correctly would be to use the centers of the keys and work with the css transform:rotate and transform:origin. I.e. let the browser handle the rendering. But I have a hard time trying to understand the math used to determine the correct location of the keys. I'll simplify this case with a 6 key keyboard hopefully this weekend. |
Yeah definitely a rotation point issue @mullinmax 👍 Ooowwwkaaayyy.... 🤦 🤒 |
Sorry, that last image was a lie. I was testing with modified code :( |
I'll take a look at it later and see if I can't find the right formula. I think KLE sets it up oddly. It probably makes sense to write a function the just aligns keys based on the center of the switch and not the top left corner. |
Looking at the html it looks like KLE already does exactly that. |
This looks like more of a rewrite than I bargained for :/ |
I'm working on a handwired board with rotated keys. In order to make a checklist I thought it would be easy to have a flipped layout (just to print out a hard copy).
Then I noticed something seemed off :)
Will try to look if I can fix this 'issue' myself.
The text was updated successfully, but these errors were encountered: