wayland: Add WindowExtWayland::xdg_toplevel
#4076
Open
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We can not expose objects from SCTK like that. We can expose a pointer, but that's about it. |
|
Thanks for the review. I have changed the method to return |
|
You should open your changes against master. |
ultimaweapon
requested review from
jackpot51,
notgull,
daxpedda,
madsmtm and
MarijnS95
as code owners
|
Ops sorry for triggering additional review requests. I have cherry-pick my commits to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelogmodule if knowledge of this change could be valuable to usersI did not update changelog yet because I don't know if this change is okay or not.
Resolves #4068.