Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Scrapy Crawlers #510

Open
Anmolbansal1 opened this issue Jan 23, 2020 · 6 comments
Open

Add tests for Scrapy Crawlers #510

Anmolbansal1 opened this issue Jan 23, 2020 · 6 comments
Milestone

Comments

@Anmolbansal1
Copy link
Collaborator

Expected Behavior

There should be a test method to test all scrapy crawlers for -

  • consistent output across all crawlers
  • proper hyperlinks in pages
  • all content is extracted from news page
  • they should be lite such that they can be enforced with travis ci

Current Behavior

Currently there are no tests.

Context

Tests makes the coding process more Agile. When more and more crawlers are added to scrapy project, sometimes structure needs to be changed. However, changing already-tested code is both risky and costly. If we have unit tests in place, then we can proceed for refactoring confidently.

Reference - Scrapy Contracts

@carpecodeum
Copy link
Contributor

can i work on this?

@Kunal614
Copy link

Kunal614 commented Feb 4, 2020

can i work on this ?

@Anmolbansal1
Copy link
Collaborator Author

Yes sure!!

@Anmolbansal1
Copy link
Collaborator Author

@Kunal614 any update??

@Anmolbansal1 Anmolbansal1 added this to the v1.0 milestone Feb 27, 2020
@Kunal614
Copy link

@Anmolbansal1
my mid-sem was going on , so now i will continue , can you explain what to do.

@Anmolbansal1
Copy link
Collaborator Author

@Kunal614 You need set up structure to test scrapy crawlers and ensure that they provide data in proper format and none of the columns are missing. Also integerate them to Travis CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants