Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ĺ and ĺ replacing with L, l to charmap #94

Open
tomasgibas opened this issue Nov 4, 2020 · 3 comments
Open

Add Ĺ and ĺ replacing with L, l to charmap #94

tomasgibas opened this issue Nov 4, 2020 · 3 comments

Comments

@tomasgibas
Copy link

tomasgibas commented Nov 4, 2020

code:

const slugify = require('slugify');

text = slugify('stĺp', {
  lower: false
});
console.log(text);
@simov
Copy link
Owner

simov commented Feb 21, 2021

Is that an error according to your locale? If that's the case then you can submit a PR with the correct replacements for your locale here https://github.com/simov/slugify/blob/master/config/locales.json, only the offending ones.

@simov simov added the question label Feb 21, 2021
@Trott
Copy link
Collaborator

Trott commented Feb 22, 2021

This would be Slovak (sk). The Slovak alphabet has a few letters that other languages don't. Those letters appear to be missing so I think these would be letters to add to the charmap rather than locales overrides. See Trott/slug@a7cf675 for what was added to slug to support Slovak.

@simov
Copy link
Owner

simov commented Feb 22, 2021

Thanks, that makes sense, I can probably use that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants