Use new contract syntax for non-complex contracts #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In principle, yes. But for some of these, the end result loses in readability. For most, it's an improvement. This PR is a good example of why splitting things up is valuable. Let's not discuss each instance in this PR while most could be merged today. Instead, let's split this PR up into several that only move a file or a couple of related files, so most of it gets merged right away and we can discuss the specific cases where the result is not a slam dunk. |
This was referenced Nov 7, 2023
|
Here we go, I’ve split it up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #249.
All formatting changes – incl. readability degradations – by sdfmt.