Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When auto-fixing, added line-ending should match line-ending of file being edited #665

Open
somewhatabstract opened this issue Jun 15, 2021 · 0 comments
Open

When auto-fixing, added line-ending should match line-ending of file being edited #665

somewhatabstract opened this issue Jun 15, 2021 · 0 comments
Assignees
@somewhatabstract
Labels
bug Something isn't working enhancement New feature or request

Comments

@somewhatabstract
Copy link
Owner

When auto-fixing, we use the \n character as a line-ending, but on Windows, the line-ending is more likely to be \r\n. We could use os.EOL but this may not match the file that we are fixing, so we should probably detect the line ending during parsing and then use that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@somewhatabstract somewhatabstract

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@somewhatabstract