Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning: componentWillUpdate has been renamed #436

Open
the-serious-programmer opened this issue Mar 28, 2022 · 2 comments
Open

Warning: componentWillUpdate has been renamed #436

the-serious-programmer opened this issue Mar 28, 2022 · 2 comments

Comments

@the-serious-programmer
Copy link

Using the package as follows:

const markdownValue = ReactRTE.createValueFromString(A_STRING_CONTAINING_HTML, 'html');
<ReactRTE
  value={markdownValue}
  readOnly
  rootStyle={{
    border: 'none',
    backgroundColor: theme.palette.background.default,
    color: theme.palette.text.primary,
    fontFamily: theme.typography.fontFamily,
  }}
>

Leads to the following warning in my browser console:

Warning: componentWillUpdate has been renamed, and is not recommended for use. See https://reactjs.org/link/unsafe-component-lifecycles for details.

* Move data fetching code or side effects to componentDidUpdate.
* Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this warning in non-strict mode. In React 18.x, only the UNSAFE_ name will work. To rename all deprecated lifecycles to their new names, you can run `npx react-codemod rename-unsafe-lifecycles` in your project source folder.

Please update the following components: e
@tiagojufr
Copy link

This blocks apps that use react-rte to migrate to React 18

@Thremulant
Copy link

Having the same warning in my components

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants