Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StatusButton] missing "outline" variant #17124

Open
caybro opened this issue Jan 24, 2025 · 0 comments · May be fixed by #17125
Open

[StatusButton] missing "outline" variant #17124

caybro opened this issue Jan 24, 2025 · 0 comments · May be fixed by #17125
Assignees
@caybro
Labels
chore StatusQ Issues related to the StatusQ library
Milestone
2.33.0 Beta

Comments

@caybro
Copy link
Member

caybro commented Jan 24, 2025

Description

It turns out we are missing the "outline" variant from our StatusBaseButton

Image

Image

We usually resort to configuring it manually, ie:

normalColor: "transparent"
borderWidth: 1
borderColor: Theme.palette.baseColor2

So it makes sense to add a property bool isOutline with the above values to have it available by default for each user of the component
@caybro caybro added chore StatusQ Issues related to the StatusQ library labels Jan 24, 2025
@caybro caybro added this to the 2.33.0 Beta milestone Jan 24, 2025
@caybro caybro self-assigned this Jan 24, 2025
@caybro caybro moved this to In Progress in Status Desktop/Mobile Board Jan 24, 2025
@caybro caybro changed the title StatusButton: missing "outline" variant [StatusButton] missing "outline" variant Jan 24, 2025
caybro added a commit that referenced this issue Jan 24, 2025
@caybro
feat(StatusButton): add an outline variant
7790c72 
- only for `StatusButton` as for the `StatusFlatButton` it's not desired
- also use defined metrics for padding/spacing

Fixes #17124
@caybro caybro moved this from In Progress to Code Review in Status Desktop/Mobile Board Jan 24, 2025
@caybro caybro linked a pull request Jan 24, 2025 that will close this issue
feat(StatusButton): add an "outline" variant #17125
Open
2 tasks
@caybro caybro linked a pull request Jan 24, 2025 that will close this issue
Open
2 tasks
caybro added a commit that referenced this issue Jan 25, 2025
@caybro
feat(StatusButton): add an outline variant
d8dd38c 
- only for `StatusButton` as for the `StatusFlatButton` it's not desired
- also use defined metrics for padding/spacing
- add a QML test

Fixes #17124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caybro caybro

Labels
chore StatusQ Issues related to the StatusQ library
Projects
Status Desktop/Mobile Board
Status: Code Review
Milestone
2.33.0 Beta
Development

Successfully merging a pull request may close this issue.

feat(StatusButton): add an "outline" variant status-im/status-desktop
1 participant
@caybro