Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding funcunit tests back #33

Closed
cherifGsoul opened this issue Apr 18, 2019 · 3 comments · Fixed by #36
Closed

Adding funcunit tests back #33

cherifGsoul opened this issue Apr 18, 2019 · 3 comments · Fixed by #36
Assignees
@cherifGsoul

Comments

@cherifGsoul
Copy link
Contributor

To make v2.0.0 release funcunit was not working with QUnit2so the tests with funcunit was dropped until the issue will be fixed.
@cherifGsoul cherifGsoul self-assigned this Apr 18, 2019
@chasenlehara
Copy link
Contributor

@kdillon Have you been working on QUnit 2 support in FuncUnit?

@cherifGsoul
Copy link
Contributor Author

bitovi/funcunit#234

@kdillon
Copy link

kdillon commented Apr 20, 2019 •
edited
Loading

Hi @chasenlehara , @cherifGsoul . Yes the QUnit 2 stuff is in for FuncUnit. Its waiting on review.

bitovi/funcunit#240

I would just push it, but as you know Chasen, my local funcunit project is currently borked for some reason, and so I can't independently verify that the change merged elegantly. However it does appear to have passed in Travis.

@cherifGsoul cherifGsoul mentioned this issue Nov 19, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cherifGsoul cherifGsoul

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put back funcunit integration tests stealjs/steal-qunit
3 participants
@cherifGsoul @kdillon @chasenlehara