Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGE] Add libmagic for cross check with siegfried #1

Open
steffenfritz opened this issue Sep 30, 2023 · 3 comments
Open

[CHANGE] Add libmagic for cross check with siegfried #1

steffenfritz opened this issue Sep 30, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@steffenfritz
Copy link
Owner

Is your feature request related to a problem? Please describe.
To use siegfried as the only sourfe for file identification is not a good idea as there might be wrong identifications.

Describe the solution you'd like
libmagic can be easly added and its identification can be cross checked with sf's results.

@steffenfritz steffenfritz added the enhancement New feature or request label Sep 30, 2023
@steffenfritz steffenfritz self-assigned this Sep 30, 2023
@dla-kramski
Copy link

I like the idea of including libmagic as another format recognition tool.

However, the column names such as filesfformatname would then have to clearly indicate which tool they come from.

I would also advise against evaluating libmagic and Siegfried results and postulating a common "main format" in case of recognition conflicts (or in general). That is a decision that should be made by the users.

@steffenfritz
Copy link
Owner Author

filesfformatname is always siegfried (the "sf" infix). magic should have its own column, yes.

@steffenfritz
Copy link
Owner Author

Check if Magika might be a useful addition, see https://github.com/google/magika/tree/main/go

Buzzword alert: AI!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants