-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warning occur when use react-loadable-visibility,but react-loadable is ok #35
Comments
Hmmmm that's an odd warning because we don't even have Are you able to reproduce this issue in a CodeSandbox or a repo that I can look at? |
I have exactly the same issue, I'm updating the react-router-dom package and it start give me that warning and the components don't load after that |
Thanks @rvntone! Are you able to reproduce the issue in a CodeSandbox or a repo by any chance? As mentioned above, we don't actually reference |
I have something similar, plus this kind of warning.
Update 1: I am still unable to reproduce it in a sandbox, meanwhile I try to switch from react-loadable-visibility with react react-loadable to just react-loadable. In this way I cut off all warnings of "React does not recognize..", but still It shows me one warning:
Update 2: @tazsingh Got it. Warnings are showed when when we use a camel case prop in our dynamic imported component. Sandbox here. Update 3:
|
I think this is because all of the props are spread on to the wrapper |
Currently all props are being spread onto the wrapping `div` elements, this is causing react to complain about unknown props on DOM elements. I can't see an obvious reason for the spread given that props intended for the lazy-loaded component should not need to be present on a wrapper element. So, this PR removes the spreads entirely.
warning occur when use react-loadable-visibility,but using react-loadable is ok
package.json
using react-loadable is ok
but react-loadable-visibility/react-loadable,warning happen
The text was updated successfully, but these errors were encountered: