Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

innerRef -> ref #4

Open
quantizor opened this issue Oct 9, 2018 · 2 comments
Open

innerRef -> ref #4

quantizor opened this issue Oct 9, 2018 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed v4

Comments

@quantizor
Copy link
Contributor

No description provided.

@quantizor quantizor added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers v4 labels Oct 9, 2018
@mxstbr
Copy link
Member

mxstbr commented Oct 10, 2018

This will be really hard to do since we can't keep track of which components are s-c and which ones aren't. People might be using innerRef for other components, it's become a bit of a convention by now...

@StevenLangbroek
Copy link
Contributor

I wouldn't recommend it for this case as it'll be a ton of work, but you could make a tool that proposes changes file by file, prompting approval accompanied by a diff snippet, as well as "links" to the files and line numbers that changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed v4
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@StevenLangbroek @quantizor @mxstbr