Download url incorrect on mac

[david-martin]

Sometimes on mac, the curl response from github is a single line rather than formatted json.
This happens more often than not and I can't determine the cause.
It looks like the same kind of problem as the kustomize install script here.

If I try the cmd it's attempting to run, you can see the wrong url being parsed out:

curl -fsSL https://api.github.com/repos/submariner-io/releases/releases/latest | grep 'browser_download_url.*-darwin-amd64' | head -n 1 | cut -d\" -f 4
https://api.github.com/repos/submariner-io/releases/releases/107454110

However, if you pipe the output from curl to jq, the url is correct.

curl -fsSL https://api.github.com/repos/submariner-io/releases/releases/latest | jq | grep 'browser_download_url.*-darwin-amd64' | head -n 1 | cut -d\" -f 4
https://github.com/submariner-io/releases/releases/download/v0.15.1/subctl-v0.15.1-darwin-amd64.tar.xz

[maayanf24]

@david-martin - We don't think the issue here is in Submariner.

[david-martin]

@david-martin - We don't think the issue here is in Submariner.

Agreed.
However it could be fixed with a change to the download script?
Specifically here? https://github.com/submariner-io/get.submariner.io/blob/devel/index.html#L116

If that's not something you want to fix though, I understand.

[tpantelis]

However, if you pipe the output from curl to jq, the url is correct.

This assumes jq is installed. It isn't on my MAC.

[david-martin]

@tpantelis I'm not suggesting that as the fix.
Using 'jq' demonstrates how the script makes an assumption about the response from github i.e. that it is always formatted a specific way.