Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for other cable drivers as well #175

Closed
Jaanki opened this issue Jul 19, 2022 · 7 comments
Closed

Add tests for other cable drivers as well #175

Jaanki opened this issue Jul 19, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@Jaanki
Copy link
Contributor

Jaanki commented Jul 19, 2022

Currently, subctl tests for default cable driver only. Add tests to run against all PRs for other cable drivers as well.

@Jaanki Jaanki added the bug Something isn't working label Jul 19, 2022
@tpantelis
Copy link
Contributor

We decided to run a minimal set of tests in subctl. Also submariner-operator doesn't even run cable driver tests. The submariner repo tests all those.

@mkolesnik
Copy link
Contributor

What's the value of having a full e2e matrix?

There's nothing in the e2e tests that actually verifies that any given flag that you set is actually getting deployed (which is a bigger problem but not directly related to this).

You could have simple unit tests to achieve the same goal - see that a flag that you set gets passed down as is to the CR that gets created.
Or if you want you could say that we want to add it to system tests, but since the whole point is to test that a flag gets passed down to a CR I think it's overkill.

@tpantelis
Copy link
Contributor

You could have simple unit tests to achieve the same goal - see that a flag that you set gets passed down as is to the CR that gets created.

👍

@stale
Copy link

stale bot commented Nov 23, 2022

This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Nov 23, 2022
@dfarrell07
Copy link
Member

Discussing on the PR scrub, it seems to make sense to have system tests in the operator to verify cable drivers we request are deployed and/or to have unit tests in subctl to verify the submariner object's cable driver flag is set properly.

@stale stale bot removed the wontfix This will not be worked on label Nov 29, 2022
@dfarrell07
Copy link
Member

Unit test part: #408

@dfarrell07
Copy link
Member

System tests: submariner-io/submariner-operator#2373

@dfarrell07 dfarrell07 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants