-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for other cable drivers as well #175
Comments
We decided to run a minimal set of tests in subctl. Also submariner-operator doesn't even run cable driver tests. The submariner repo tests all those. |
What's the value of having a full e2e matrix? There's nothing in the e2e tests that actually verifies that any given flag that you set is actually getting deployed (which is a bigger problem but not directly related to this). You could have simple unit tests to achieve the same goal - see that a flag that you set gets passed down as is to the CR that gets created. |
👍 |
This issue has been automatically marked as stale because it has not had activity for 60 days. It will be closed if no further activity occurs. Please make a comment if this issue/pr is still valid. Thank you for your contributions. |
Discussing on the PR scrub, it seems to make sense to have system tests in the operator to verify cable drivers we request are deployed and/or to have unit tests in subctl to verify the submariner object's cable driver flag is set properly. |
Unit test part: #408 |
System tests: submariner-io/submariner-operator#2373 |
Currently, subctl tests for default cable driver only. Add tests to run against all PRs for other cable drivers as well.
The text was updated successfully, but these errors were encountered: