Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No menu at certain viewport widths #676

Closed
arichardsmith opened this issue Oct 28, 2024 · 2 comments
Closed

No menu at certain viewport widths #676

arichardsmith opened this issue Oct 28, 2024 · 2 comments

Comments

@arichardsmith
Copy link

arichardsmith commented Oct 28, 2024

In the docs, there is a small interval (~32px) where the mobile menu on the bottom is hidden, but the sidebar isn't shown yet. This leaves clicking through page by page as the only way to navigate. To make it worse, an iPad Air in portrait mode happens to fall exactly in this dead spot!

I might be getting which-component-renders-what wrong, but it looks like the mobile menu (from packages/site-kit?) nav gets hidden at 800px, while the sidebar (docs layout component?) is hidden until 832px.

I'm happy to try to fix it and submit a PR. I guess you'd want to keep the mobile nav until 832px? That would be a smaller change than making the sidebar appear from 800px. But is site-kit being used elsewhere?

@Rich-Harris
Copy link
Member

This was coincidentally fixed in #679, before I saw this issue! Thanks for the report

@arichardsmith
Copy link
Author

Awesome, thank you! Back to perusing the new docs on my iPad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants