Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Caddy v2.9.0 Updates #85

Open
kernelb00t opened this issue Jan 4, 2025 · 2 comments
Open

[BUG] Caddy v2.9.0 Updates #85

kernelb00t opened this issue Jan 4, 2025 · 2 comments

Comments

@kernelb00t
Copy link

kernelb00t commented Jan 4, 2025

16.50 2025/01/04 13:23:57 [INFO] exec (timeout=0s): /usr/local/go/bin/go build -o /usr/bin/caddy -ldflags -w -s -trimpath -tags nobadger,nomysql,nopgx 
53.90 # github.com/tailscale/caddy-tailscale
53.90 /go/pkg/mod/github.com/tailscale/[email protected]/module.go:34:37: cannot use getTCPListener (value of type func(c "context".Context, _ string, addr string, _ net.ListenConfig) (any, error)) as caddy.ListenerFunc value in argument to caddy.RegisterNetwork
53.90 /go/pkg/mod/github.com/tailscale/[email protected]/module.go:35:41: cannot use getTLSListener (value of type func(c "context".Context, _ string, addr string, _ net.ListenConfig) (any, error)) as caddy.ListenerFunc value in argument to caddy.RegisterNetwork
53.90 /go/pkg/mod/github.com/tailscale/[email protected]/module.go:36:41: cannot use getUDPListener (value of type func(c "context".Context, _ string, addr string, _ net.ListenConfig) (any, error)) as caddy.ListenerFunc value in argument to caddy.RegisterNetwork

Seems that the new Caddy v2.9.0 broke things.

Env:
Custom Dockerfile, building with Go 1.23 (golang:1.23-alpine3.20), XCADDY_VERSION=v0.4.4, and caddy-tailscale on f21c01b.

@kernelb00t
Copy link
Author

That's the problem:
The type signature of ListenerFunc changed.
https://github.com/caddyserver/caddy/blame/master/listeners.go#L679

@kernelb00t
Copy link
Author

Relevant PR: #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant