Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] K256 Keystore Sign Prehash + Recovery ID #612

Open
shekohex opened this issue Jan 22, 2025 · 0 comments
Open

[FEATURE REQUEST] K256 Keystore Sign Prehash + Recovery ID #612

shekohex opened this issue Jan 22, 2025 · 0 comments
Assignees
@shekohex
Labels
feature ➕ Tasks that are functional additions or enhancements p1 🟠 Issue should be resolved sooner than later task ✔️

Comments

@shekohex
Copy link
Contributor

Currently, the K256 Key-type in the Keystore does not return RecoveryId when signing a Prehashed value.

We already have the value here:
https://github.com/tangle-network/gadget-workspace/blob/62081e734398a982f290041bc6ecf5003c23704d/crates/crypto/k256/src/lib.rs#L182-L191

Another feature request, we have sign_with_local method in the backends, but we do not have sign_prehashed_with_local

https://github.com/tangle-network/gadget-workspace/blob/62081e734398a982f290041bc6ecf5003c23704d/crates/keystore/src/keystore/mod.rs#L172-L182
@shekohex shekohex added feature ➕ Tasks that are functional additions or enhancements p1 🟠 Issue should be resolved sooner than later task ✔️ labels Jan 22, 2025
@shekohex shekohex self-assigned this Jan 23, 2025
@Tjemmmic Tjemmmic transferred this issue from tangle-network/gadget-workspace Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shekohex shekohex

Labels
feature ➕ Tasks that are functional additions or enhancements p1 🟠 Issue should be resolved sooner than later task ✔️
Projects
Webb Universe
Status: Not Started 🕧
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shekohex