Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add IDs for keys in the keystore #613

Open
Serial-ATA opened this issue Jan 9, 2025 · 0 comments
Open

[TASK] Add IDs for keys in the keystore #613

Serial-ATA opened this issue Jan 9, 2025 · 0 comments
Labels
feature ➕ Tasks that are functional additions or enhancements p0 🔥 Critical issues that need to be resolved immediately task ✔️

Comments

@Serial-ATA
Copy link
Contributor

There's no (easy) way to get a key without knowing its public key. We should support allowing users to specify a key ID (such as "tangle-default").

Unresolved Questions

  • How does this work with the current API?

Right now, load()ing a key expects <T as KeyType>::Public. How do we allow for loading by ID, and how do we want to handle the case of generating a key with an ID and then attempting to load it by its public key?

  • How should this be handled in the filesystem storage?

Right now, the filesystem storage will name files with a hash of their public key. Should they now be named by their IDs? This ties into the previous question, how will we find those key files now if they are named by their ID and we attempt to lookup by public key?

@Serial-ATA Serial-ATA added feature ➕ Tasks that are functional additions or enhancements task ✔️ p0 🔥 Critical issues that need to be resolved immediately labels Jan 9, 2025
@Tjemmmic Tjemmmic transferred this issue from tangle-network/gadget-workspace Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ➕ Tasks that are functional additions or enhancements p0 🔥 Critical issues that need to be resolved immediately task ✔️
Projects
Status: Not Started 🕧
Development

No branches or pull requests

1 participant