Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no way to activate "Show Example" using keyboard navigation #147

Closed
michaelficarra opened this issue Mar 26, 2019 · 1 comment · Fixed by #200
Closed

no way to activate "Show Example" using keyboard navigation #147

michaelficarra opened this issue Mar 26, 2019 · 1 comment · Fixed by #200
Labels
bug Something isn't working

Comments

@michaelficarra
Copy link
Member

I can't figure out how someone navigating only via keyboard (or I'm assuming screen reader) would show or hide the examples. You can't tab to it since it's just a <div>, and even if you could, it can't be activated with the keyboard. I think this will cause accessibility issues.

This may be addressed by replacing the "show example" feature with something else, as in #105.

@codehag
Copy link
Collaborator

codehag commented Apr 15, 2019

Hi @michaelficarra -- thanks for pointing this out, this is a regression

@codehag codehag added the bug Something isn't working label Apr 15, 2019
DerekNonGeneric added a commit to DerekNonGeneric/tc39.github.io that referenced this issue Jul 14, 2020
Prior to this commit, depending on the browser being used, it may
have been quite difficult to see which element was in focus when
navigating the page using the tab key. This has been corrected by
adjusting the `:focus` pseudo-class styles for selectable elements
so that it no longer depends on inconsistent user-agent styles.

Notes:
    https://user-images.githubusercontent.com/17770407/87440188-b38cdc80-c5bf-11ea-86e3-8b1c8652e25b.png
    https://user-images.githubusercontent.com/17770407/87440518-141c1980-c5c0-11ea-964f-70ff56523438.png

Fixes: tc39#147
codehag added a commit that referenced this issue Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants