Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fit=crop should use the resize cover method from Intervention #420

Closed
deluxetom opened this issue Jan 6, 2025 · 0 comments
Closed

fit=crop should use the resize cover method from Intervention #420

deluxetom opened this issue Jan 6, 2025 · 0 comments
Milestone
3.x

Comments

@deluxetom
Copy link

When possible, Glide should use the built-in methods from Intervention:
https://image.intervention.io/v3/modifying/resizing#cropping--resizing-combined

I noticed differences when fit=crop was used, the way the crop is calculated in glide can create 1px differences.
@deluxetom deluxetom mentioned this issue Jan 6, 2025
Merged
@ADmad ADmad closed this as completed Jan 20, 2025
@ADmad ADmad added this to the 3.x milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.x
Development

No branches or pull requests
2 participants
@ADmad @deluxetom