syncer: exit broadcast as soon as possible #9018
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Signed-off-by: Ryan Leung <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #9018 +/- ##
==========================================
+ Coverage 76.25% 76.27% +0.01%
==========================================
Files 466 466
Lines 70733 70740 +7
==========================================
+ Hits 53938 53957 +19
+ Misses 13437 13427 -10
+ Partials 3358 3356 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
rleungx
force-pushed
the
exit-broadcast-immediately
branch
from
fae0a07 to
3f64d88
Compare
nolouch
reviewed
Jan 23, 2025
Signed-off-by: Ryan Leung <[email protected]>
nolouch
approved these changes
Jan 23, 2025
[LGTM Timeline notifier]Timeline:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nolouch The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
JmPotato
reviewed
Jan 24, 2025
| var failed []string | ||
| s.mu.RLock() | ||
| for name, sender := range s.mu.streams { | ||
| err := sender.Send(regions) |
There was a problem hiding this comment.
Do we need to check ctx.Done here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #9017
What is changed and how does it work?
Check List
Tests
Release note