Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metrics] Decide global logging for a request on the metric handler side #562

Open
rahulbabu95 opened this issue Nov 26, 2024 · 0 comments

Comments

@rahulbabu95
Copy link
Contributor

In middleware.go where we log globally for each HTTP request, we have a hardcoded logic to determine if the request came in for metrics handler using the uri to determine that global logging is required. A similar use case in ISO is handled by setting the 'X-Global-Logging' field in the response Header. This arguably isolates individual handlers to opt in/out of global logging and keeps component specific logic away from middleware.

Expected Behaviour

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant