Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get latest PR body before updating the PR body with links #92

Open
domenic opened this issue Jun 28, 2021 · 0 comments
Open

Get latest PR body before updating the PR body with links #92

domenic opened this issue Jun 28, 2021 · 0 comments

Comments

@domenic
Copy link
Contributor

domenic commented Jun 28, 2021

Consider the following scenario, which occurs pretty often for HTML:

  1. A PR is uploaded.
  2. PR preview grabs the PR body text and commit contents.
  3. Within the next 30 seconds, I edit the PR body text using GitHub's web UI
  4. PR preview finishes building (~30 seconds later). It replaces the PR body text with the text from step (2) + its links to the preview. Thus, my edits are lost.

This problem is compounded if one is simultaneously pushing new commits and editing the PR body text in an intertwined fashion.

It would be ideal if once PR preview finished building in step 4, it grabbed a fresh copy of the PR body text to add its links to. This would greatly reduce the window in which edits could be lost: it would go down from "while the PR is being built" (which can be long) to "in between the fetch-new-body network request and the post-new-body network request".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant