Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Provider/SearchProvider #4308

Closed
mifi opened this issue Feb 7, 2023 · 0 comments · Fixed by #4330
Closed

Merge Provider/SearchProvider #4308

mifi opened this issue Feb 7, 2023 · 0 comments · Fixed by #4330
Labels
Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) Feature

Comments

@mifi
Copy link
Contributor

mifi commented Feb 7, 2023 •
edited
Loading

searchprovider was added in #2431 in order to accomodate Unsplash. However we believe that those two concepts can be merged. Currently only Provider can be extended by user. Want to try to make a common abstraction that works for both.

also transloadit/uppy.io#41
@mifi mifi added Feature Triage Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) labels Feb 7, 2023
mifi added a commit that referenced this issue Feb 23, 2023
@mifi
merge search provider and provider
36d2dfd 
closes #4308
@mifi mifi mentioned this issue Feb 23, 2023
Merged
mifi added a commit that referenced this issue Mar 28, 2023
@mifi
@uppy/companion: merge Provider/SearchProvider (#4330)
596989d 
* merge search provider and provider

closes #4308

* simplify and improve naming

* Apply suggestions from code review

* fix test

need to have an authProvider for a grantConfig to be set
previously we didn't care, so this test was a bit wrong

* Update packages/@uppy/companion/src/server/provider/Provider.js

* fix merge oops
HeavenFox pushed a commit to docsend/uppy that referenced this issue Jun 27, 2023
@mifi
@uppy/companion: merge Provider/SearchProvider (transloadit#4330)
ac43869 
* merge search provider and provider

closes transloadit#4308

* simplify and improve naming

* Apply suggestions from code review

* fix test

need to have an authProvider for a grantConfig to be set
previously we didn't care, so this test was a bit wrong

* Update packages/@uppy/companion/src/server/provider/Provider.js

* fix merge oops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

@uppy/companion: merge Provider/SearchProvider transloadit/uppy
1 participant
@mifi