Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hive Metastore Cache for Iceberg metadata (list tables) #13115

Open
osscm opened this issue Jul 7, 2022 · 2 comments · May be fixed by #24797
Open

Hive Metastore Cache for Iceberg metadata (list tables) #13115

osscm opened this issue Jul 7, 2022 · 2 comments · May be fixed by #24797

Comments

@osscm
Copy link
Contributor

osscm commented Jul 7, 2022

Hive Metastore Caching is disabled in the Iceberg connector.
https://github.com/trinodb/trino/blob/master/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/IcebergCatalogModule.java#L69-L78

Though the Iceberg table doesn't store information like the table's partition, if the list of tables itself is large (in 1000s) then calls like show tables or queries for system.jdbc.tables table to get all the tables from all the schemas across all of the catalog/connectors can also result in listing tables.

Calls to get metadata/tables can be quite frequent from the SQL Editors/DBeaver or applications which are also showing/using metadata.
So, if we cache this data in Trino, then can avoid fetching it all the time from HMS for every request from the clients.

@findepi
Copy link
Member

findepi commented Jul 20, 2022

Yes, we should have an option to cache list of tables.

cc @electrum @alexjo2144 @findinpath

@findinpath
Copy link
Contributor

Related PR where metastore caching was removed from Iceberg

#5303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants