Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support poison values #184

Open
int3 opened this issue Dec 6, 2024 · 1 comment
Open

Support poison values #184

int3 opened this issue Dec 6, 2024 · 1 comment

Comments

@int3
Copy link
Collaborator

int3 commented Dec 6, 2024

The test added in triton-lang#4896 fails right now with an "LLVM Translation failed" error. The fix should be pretty simple; we just need to add a call to mlir::ub::populateUBToLLVMConversionPatterns like the nvidia/amd backends have done. However, since we use a somewhat different pass organization structure, we don't have a generic pattern conversion pass to put this into. I tried adding the conversion in FuncOpToLLVM, and while translation succeeds, the poison value is still missing from the llir output; I think it's getting DCE'd away. Not sure if this is a pass ordering issue, or if the test should just be made more flexible...

This doesn't seem super critical so I'm just filing an issue for now

@ienkovich
Copy link
Collaborator

We can add a proper pass to our pipeline similar to other upstream dialects lowering passes. It can be created using createUBToLLVMConversionPass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants