Coverage is not properly calculated

[charlesBochet]

Scope & Context

We have recently updated the way storybook tests are run. However, the coverage does not seems to be properly computed anymore on the CI:

See:

As you can see, only a few files (probably the one impacted by the tests) are taken into account. We would like the whole packages/twenty-front to be considered (actually it should respect includes/excludes specified in nyc.config.cjs)

Technical inputs

To reproduce run:

• npx nx run twenty-front:storybook:static:test --configuration=modules
• or npx nx run twenty-front:storybook:static:test --configuration=pages

The coverage is properly computed if we run the following commands

• npx nx run twenty-front:storybook:build (this is not scoped on modules / pages)
• then npx nx run twenty-front:storybook:test --configuration=modules
• or npx nx run twenty-front:storybook:test --configuration=pages

[charlesBochet]

@gitstart-twenty Could you have a look? It needs some strong investigation skills!

[gitstart-app]

Here is the GitStart Ticket for this issue: https://clients.gitstart.com/twenty/5449/tickets/TWNTY-5519

[charlesBochet]

@gitstart-twenty The command have been updated, here is how to reproduce the issue today:

Dev (hot reload) serve:

• npx nx run twenty-front:storybook:serve:dev
• npx nx run twenty-front:storybook:test --configuration=modules

Static serve:

• npx nx run twenty-front:storybook:serve:static
• npx nx run twenty-front:storybook:test --configuration=modules

As you can see, most of the files are missing from the code coverage computation (it seems that the coverage only takes files touched by tests into account)

[charlesBochet]

As you pointed @gitstart-twenty, changes were made in the following commit: 6683ffb?diff=split&w=0

I believe that the problem was already there in the commit above but if you checkout before this commit and run:

• npx nx run twenty-front:storybook:build
• npx nx run twenty-front:storybook:test --configuration=modules

the coverage was correct.

The goal of this ticket is to use the current commands but have the coverage properly computed

[gitstart-twenty]

Thank you. We will work on it.

[charlesBochet]

This has been investigated and fixed by @prastoin, closing this issue in #9448