-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Baseui #22
Comments
Thanks for the initiative. Regarding package size in Cons: Per Ryan's comment, Shall we do around of benchmarking for the bundle size first, and seek help from BaseUI/Kepler.gl if the size is significantly large? |
I'm not a big fan of styled-components. I prefer using UI tools such as baseui or antd and manage css customization through sass or less. You can maintain a namespace scheme to associate each sass file to a component, which basically negates the necessity of using styled components. Namespace as such: feature-list-drawing.sass
feature-list-drawing.js
|
How significant is this consideration? If it's not a huge increase in package size in terms of proportion to the current package, then the middle-ground solution seems to be low-hanging to test. |
Current bundle size for the demo website build:
|
Resolved by #50 |
Currently, within Manifold package we are using
styled-components
to do custom styling; it becomes complicated for advanced UI widgets (e.g. select with searching functionalities) and hinders development speed.Pros:
Cons:
Middle-ground solution: we could keep styled-components for e.g. styling divs and only use Baseui for UI widgets for now, so that the refactoring work will not involve refactoring styled-component css-like strings to styletron objects:
The text was updated successfully, but these errors were encountered: