Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vehicle damage max length #277

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Vehicle damage max length #277

wants to merge 4 commits into from

Conversation

avacmeyer
Copy link
Contributor

closes #169.

werebus
werebus reviewed Oct 23, 2020
View reviewed changes
Copy link
Member

@werebus werebus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick thing to note, this validation makes 60 IncidentReports in production invalid.

Was 50 a hard requirement? I'll be honest, I looked at the "invalid" descriptions, and none of them really seemed excessively long, and all but 4 of them were less than 100 characters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@werebus werebus werebus left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rails Validations for Fields
2 participants
@avacmeyer @werebus