Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install dependencies after cloning not working with pnpm-workspace #128

Open
Callan003 opened this issue Jan 4, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@Callan003
Copy link

Environment

Node: v20.10.0
"nuxt": "^3.9.0",
"vue": "^3.4.3",
"vue-router": "^4.2.5"

Reproduction

Method1:

  1. https://github.com/Callan003/test-nuxt-layers
  2. run pnpm install - it will get stuck
  3. remove pnpm-workspace.yaml
  4. run pnpm install - it works
  5. optional: remove old node_modules and pnpm-lock between step 3 and 4 just to be sure it is a clean build

Method2:

  1. https://github.com/Callan003/test-nuxt-layers
  2. go to nuxt.config.ts
  3. remove { giget: { install: true } }
  4. run pnpm install - it works
  5. add { giget: { install: true } } back
  6. run pnpm install - it fails
  7. optional: remove old node_modules and pnpm-lock before running pnpm install

Describe the bug

When trying to use the new install feature with pnpm-workspace the project gets stuck on pnpm install.

I think it gets stuck on the following prompt: "The modules directory at "C:\Projects\test-nuxt-layers\a\node_modules" will be removed and reinstalled from scratch. Proceed? (Y/n)". Because running the "pnpm install" command will not 'answer' with a Y/n, the process gets stuck.

On bigger projects it will ask this prompt for each node_modules which will trigger the "MaxListenersExceededWarning: Possible EventEmmiter memory leak detected" warning. Like I mentioned here

I am not sure if it is a pnpm bug or a c12 bug, but it seems to be breaking only when using install: true and pnpm-workspace.yaml file

Additional context

No response

Logs

No response

@Callan003
Copy link
Author

@pi0 any guidance here? I'm attempting to solve this issue, and I would be grateful for any advice or tips you can offer. Thank-you!

@pi0
Copy link
Member

pi0 commented Mar 5, 2024

Hi dear @Callan003 thanks for the nice reproduction and sorry for delay on this.

I have made upstream issue in nypm that handles downloading which by default it probably has to auto skip interactive prompts like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants