feat: pass lru options through #555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes unjs#466 This changes the `lru-cache` such that the following methods accept LRU options (and pass them through to the underlying methods): - `setItem` - `setItemRaw` - `hasItem`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
==========================================
- Coverage 65.05% 58.84% -6.22%
==========================================
Files 39 43 +4
Lines 4055 3676 -379
Branches 487 587 +100
==========================================
- Hits 2638 2163 -475
- Misses 1408 1509 +101
+ Partials 9 4 -5 ☔ View full report in Codecov by Sentry. |
|
I appreciate the PR but I want to wait for v2 to standardize opts namespace before exposing more possible options (otherwise we introduce a feature that will be shortly broken) -- PS: we might want to limit some of options for lru. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #466
This changes the
lru-cachesuch that the following methods accept LRU options (and pass them through to the underlying methods):setItemsetItemRawhasItem