Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Populate index from bf16 #553

Open
2 of 3 tasks
rschu1ze opened this issue Jan 15, 2025 · 1 comment · May be fixed by #558
Open
2 of 3 tasks

Feature: Populate index from bf16 #553

rschu1ze opened this issue Jan 15, 2025 · 1 comment · May be fixed by #558
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rschu1ze
Copy link
Contributor

Describe what you are looking for

I would love to be able to populate indexes with bf16 values. The current add interface misses support for this particular type:

add_result_t add(vector_key_t key, b1x8_t const* vector, std::size_t thread = any_thread(), bool force_vector_copy = true) { return add_(key, vector, thread, force_vector_copy, casts_.from.b1x8); }
add_result_t add(vector_key_t key, i8_t const* vector, std::size_t thread = any_thread(), bool force_vector_copy = true) { return add_(key, vector, thread, force_vector_copy, casts_.from.i8); }
add_result_t add(vector_key_t key, f16_t const* vector, std::size_t thread = any_thread(), bool force_vector_copy = true) { return add_(key, vector, thread, force_vector_copy, casts_.from.f16); }
add_result_t add(vector_key_t key, f32_t const* vector, std::size_t thread = any_thread(), bool force_vector_copy = true) { return add_(key, vector, thread, force_vector_copy, casts_.from.f32); }
add_result_t add(vector_key_t key, f64_t const* vector, std::size_t thread = any_thread(), bool force_vector_copy = true) { return add_(key, vector, thread, force_vector_copy, casts_.from.f64); }

Can you contribute to the implementation?

  • I can contribute

Is your feature request specific to a certain interface?

C++ implementation

Contact Details

[email protected]

Is there an existing issue for this?

  • I have searched the existing issues

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rschu1ze rschu1ze added the enhancement New feature or request label Jan 15, 2025
@ashvardanian ashvardanian added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 15, 2025
@ashvardanian ashvardanian linked a pull request Jan 23, 2025 that will close this issue
@ashvardanian
Copy link
Contributor

@egorovcharenko is already looking into this 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants