Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #23

Open
2 of 3 tasks
yyoon opened this issue Apr 11, 2016 · 0 comments
Open
2 of 3 tasks

Improve test coverage #23

yyoon opened this issue Apr 11, 2016 · 0 comments
Assignees
@yyoon
Labels
Testing

Comments

@yyoon
Copy link

yyoon commented Apr 11, 2016 •
edited
Loading

The current code coverage for madb is 43.1%, which is not great. This is largely due to the fact that it is hard to add madb integration tests without actual devices connected to the computer. We need to find a way to test better and improve this number.

  • add more dry-run type of tests to see whether the correct adb command is called with the expected set of arguments.
  • add test coverage check in our CI. (see: https://blog.golang.org/cover)
  • add a test coverage badge in README. (might have to consider using Travis CI for this)
@yyoon yyoon added the Testing label Apr 11, 2016
@yyoon yyoon changed the title Add more dry-run type of tests for madb Improve test coverage Apr 15, 2016
@yyoon yyoon assigned yyoon and jxson and unassigned yyoon Apr 19, 2016
vanadium-bot pushed a commit that referenced this issue Apr 20, 2016
@jxson
chore(coverage, ci): add travis-ci and coveralls
ac47f71 
* Add travis-ci setup and badge
* Add coverage support to the travis build
* Report coverage results to coveralls.io and add badge

References #23

Change-Id: I9db21eb18737d5fc41fabc4b49576f76cee58bf0
@yyoon yyoon assigned yyoon and unassigned jxson Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yyoon yyoon

Labels
Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jxson @yyoon