Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make react markdown (renderer) more configurable #126

Open
elboletaire opened this issue Dec 20, 2023 · 0 comments
Open

Make react markdown (renderer) more configurable #126

elboletaire opened this issue Dec 20, 2023 · 0 comments
Labels
chakra-components Things related to the chakra-components package enhancement New feature or request

Comments

@elboletaire
Copy link
Member

elboletaire commented Dec 20, 2023

There are multiple possible solutions:

  1. Allow to pass a configuration object that would be spread to ReactMarkdown component. This should allow reconfiguring all the defined components.
  2. Additionally to be using a component to render the markdown, a simple function with the raw text could be provided, giving to the end-developer the possibility to use any renderer, and completely removing ReactMarkdown as a dependency (and would close Make react-markdown optional #5). This has a major drawback tho: it's breaking with the current behavior, and would require changes not only in ui-scaffold, but also in ui-explorer.
  3. Create a markdown context and allow to configure the Markdown component when defining such context.

I think it'll be 1, but it could be a fusion between 1 and 2 too (meaning, adding the render function logic, but maintaining the current default behavior)

@elboletaire elboletaire added enhancement New feature or request chakra-components Things related to the chakra-components package labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chakra-components Things related to the chakra-components package enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant