Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REQUEST | useDebouncedRefHistory | Can you provide a hook function to provide prev and next data to block whether to continue committing #4468

Open
7 tasks done
tetap opened this issue Jan 7, 2025 · 0 comments · May be fixed by #4471
Open
7 tasks done

REQUEST | useDebouncedRefHistory | Can you provide a hook function to provide prev and next data to block whether to continue committing #4468

tetap opened this issue Jan 7, 2025 · 0 comments · May be fixed by #4471
Labels
enhancement New feature or request has pr

Comments

@tetap
Copy link

tetap commented Jan 7, 2025

Describe the bug

When directly assigning an array ref, commit will definitely trigger. I hope that a prefix function can be provided that can return me the previous and current values to compare whether commit is really needed

Reproduction

https://stackblitz.com/edit/vitejs-vite-xo6udi6k

System Info

System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 Intel(R) Core(TM) i5-10500 CPU @ 3.10GHz
    Memory: 4.45 GB / 15.75 GB
    OS: Windows 10 10.0.19045
    CPU: (12) x64 Intel(R) Core(TM) i5-10500 CPU @ 3.10GHz
    Memory: 4.45 GB / 15.75 GB
    CPU: (12) x64 Intel(R) Core(TM) i5-10500 CPU @ 3.10GHz
    Memory: 4.45 GB / 15.75 GB
    Memory: 4.45 GB / 15.75 GB
  Binaries:
    Node: 20.16.0 - E:\nvm\nodejs\node.EXE
    Yarn: 1.22.22 - E:\nvm\nodejs\yarn.CMD
    npm: 10.8.1 - E:\nvm\nodejs\npm.CMD
    pnpm: 9.12.1 - E:\nvm\nodejs\pnpm.CMD
  Browsers:
    Edge: Chromium (129.0.2792.79)
    Internet Explorer: 11.0.19041.4355
  npmPackages:
    @vueuse/components: ^11.1.0 => 11.1.0
    @vueuse/core: ^11.1.0 => 11.1.0
    vue: ^3.5.11 => 3.5.11

Used Package Manager

npm

Validations
@ilyaliao ilyaliao added the enhancement New feature or request label Jan 7, 2025
@OrbisK OrbisK changed the title BUG | useDebouncedRefHistory | Can you provide a hook function to provide prev and next data to block whether to continue committing REQUEST | useDebouncedRefHistory | Can you provide a hook function to provide prev and next data to block whether to continue committing Jan 7, 2025
@JonathanSchndr JonathanSchndr linked a pull request Jan 7, 2025 that will close this issue
Open
@ilyaliao ilyaliao added the has pr label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request has pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(UseRefHistoryOptions): add shouldCommit JonathanSchndr/vueuse
2 participants
@tetap @ilyaliao