Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many "RFC2119 keyword in non-normative section" warnings #246

Closed
annevk opened this issue Jan 8, 2025 · 6 comments · Fixed by #247
Closed

Many "RFC2119 keyword in non-normative section" warnings #246

annevk opened this issue Jan 8, 2025 · 6 comments · Fixed by #247

Comments

@annevk
Copy link
Member

annevk commented Jan 8, 2025

What is the issue with the URL Pattern Standard?

Looking at https://github.com/whatwg/urlpattern/actions/runs/12660193496/job/35280891950 for instance I see quite a few of these. Normally these should fail the build so I don't quite understand what's going on here, but either way it seems like these should be fixed.

@sisidovski
Copy link
Collaborator

It seems that warnings appears in Run make deploy section, and the executed script is there. I don't know whether RFC2119 warnings used to make the deployment failed or not before, but I'll take a look and fix warnings anyway.

@sisidovski
Copy link
Collaborator

RFC2119 violations are warned but the CLI doesn't completed with the exit status 1. That's why the deployment isn't canceled IIUC. So maybe this is an expected behavior across repositories in this org?

@annevk
Copy link
Member Author

annevk commented Jan 8, 2025

The reason it should fail is because we have "Die On" metadata as per speced/bikeshed-boilerplate@a569466.

So something seems amiss.

@domenic @tabatkins thoughts?

@sisidovski
Copy link
Collaborator

Let me reopen this as the discussion is still ongoing.

@domenic
Copy link
Member

domenic commented Jan 17, 2025

Looks like a Bikeshed bug. I created a minimal reproduction case and filed it over there, so I think we can close this now: speced/bikeshed#3009

@domenic domenic closed this as completed Jan 17, 2025
@tabatkins
Copy link

tabatkins commented Jan 18, 2025

Actually just a bug in the WHATWG defaults (lint errors are weaker than the "warnings" that the metadata was dying on), but it should be fixed now. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

4 participants