Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCV v0.2.1 feedback #4

Open
ArekGwizdzi opened this issue Jan 11, 2025 · 0 comments
Open

MCV v0.2.1 feedback #4

ArekGwizdzi opened this issue Jan 11, 2025 · 0 comments

Comments

@ArekGwizdzi
Copy link

https://github.com/xNomad-AI/mcv/blame/5c7f6c118debfa445728955d8276a12d304c861b/src/upload.ts#L74

Hello,
Since you guys have asked for feedback on X I would like to give a small suggestion.
Mcv/src/upload.ts
Line 74 of this file is hardcoded value, you could use a constant instead

Obviously you know what you do and tech here is on point that was just a small detailed that caught my eye while reviewing.
My X:@Mati93018761
Sol public key: FyQQbwuSp6cArrXRUUc2VXQMBmfgSZDyve6Z3dN24Ciu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant