Excel like behavior for grid column filtering #3894
+77
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnrudd
requested changes
Jan 9, 2025
There was a problem hiding this comment.
Otito and I went over this several times and ironed out the kinks. My current comments are just minor linting nits.
We confirmed that the new implementation works like Excel.
We tested the following flows/cases:
- commitOnChange: true|false
- regular grid & tree grid
- statefulness when switching from value to custom tab
- hide/show "add to existing filter"
- grid font size tiny, standard, large, etc.
There is a lot to test, I don't think we missed anything, but anyone reviewing should really try to break it.
| @@ -26,6 +26,10 @@ export class ValuesTabModel extends HoistModel { | |||
| /** Bound search term for `StoreFilterField` */ | |||
| @bindable filterText: string = null; | |||
|
|
|||
| /** Available only when commit on change is false merge | |||
| * current filter with pendingValues on commit*/ | |||
There was a problem hiding this comment.
Comment layout should be corrected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.
developbranch as of last change.breaking-changelabel + CHANGELOG if so.If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.