Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve control of right elements on DateEditor #3892

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Improve control of right elements on DateEditor #3892

wants to merge 8 commits into from

Conversation

oodarluz
Copy link
Contributor

@oodarluz oodarluz commented Jan 7, 2025 •
edited
Loading

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile, or determined not required.
  • Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@oodarluz oodarluz requested a review from ghsolomon January 7, 2025 22:43
@oodarluz
Copy link
Contributor Author

oodarluz commented Jan 7, 2025 •
edited
Loading

Here are your perpetrators:

DateEditor:

hoist-react/desktop/cmp/grid/editors/DateEditor.ts

Line 37 in 8bd5d35

rightElement: null,

DateInput:

hoist-react/desktop/cmp/input/DateInput.ts

Line 414 in 8bd5d35

const rightElement = withDefault(props.rightElement, buttons);

The date editors rightElement is set to null by default which set the rightElement of the dateInput to null superseding enableClear

We can remove the line from the DateEditor. All applications using inline date editors will have the date Icon by default but will respect enableClear

image

@oodarluz oodarluz linked an issue Jan 8, 2025 that may be closed by this pull request
Inline grid DateEditor does not support enableClear #3859
Open
@oodarluz oodarluz marked this pull request as ready for review January 8, 2025 19:35
@lbwexler lbwexler changed the title Addition of inline, date buttons on grid Improve control of right elements on DateEditor Jan 9, 2025
@oodarluz oodarluz requested a review from lbwexler January 9, 2025 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghsolomon ghsolomon Awaiting requested review from ghsolomon

@lbwexler lbwexler Awaiting requested review from lbwexler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inline grid DateEditor does not support enableClear
1 participant
@oodarluz