Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move settings into a sidebar tab panel #140

Open
junhaoliao opened this issue Nov 28, 2024 · 3 comments
Open

Move settings into a sidebar tab panel #140

junhaoliao opened this issue Nov 28, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@junhaoliao
Copy link
Member

Request

Transform the settings modal into a tab panel integrated within the main sidebar, similar to the "File Info" panel. This would streamline navigation and provide a consistent user experience by avoiding disruptive modals.

Possible implementation

  1. Add a "Settings" tab: Update the sidebar to include a "Settings" tab alongside existing tabs like "File Info".
  2. Render settings UI: Move the existing settings modal content into this new tab, ensuring proper alignment and responsive design.
  3. Remove reload behavior: Eliminate the need to reload the application to get the settings applied.
  4. Persist panel state: Do not save the open/close state of the "Settings" tab across app sessions.
@junhaoliao junhaoliao added the enhancement New feature or request label Nov 28, 2024
@junhaoliao
Copy link
Member Author

@davemarco please help review

@davemarco
Copy link
Contributor

davemarco commented Dec 1, 2024

This is interesting. I have some concern that format string input is too wide for the default panel size. Maybe we could move the format string into own window out of settings? Also note that some settings affect file deserialization (log level key, timestamp key). So maybe we dont need to reload the whole viewer, but we will still need to deserialize the file again.

@junhaoliao
Copy link
Member Author

@davemarco

I have some concern that format string input is too wide for the default panel size.

If we change the element from an <Input/> into a <Textbox/> (multiline text field), do you think that would help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants