Exclamation (breaking change) is not recognized

[binarylogic]

PR titles following the ! BREAKING CHANGE syntax are not recognized as valid. For example, we have a PR title like so:

fix(config)!: ...

This does not pass validation (the PR check remains pending) even though it is valid according to the spec:

BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope

The actual PR being referenced is vectordotdev/vector#1033.

[zeke]

Thanks for opening this issue, and sorry for the delay getting back to you.

This app uses the parse-commit-message npm package to validate commits. I think the ! support needs to be added there.

cc @tunnckoCore (author of parse-commit-message) does that sound right?

[tunnckoCore]

Uh, yea, I forgot about that. I can update probably these days or at the weekend.
I'll also migrate it to https://github.com/tunnckocore/opensource.

[binarylogic]

Thanks @tunnckoCore, that would be helpful.

[tunnckoCore]

Oh, damn me, sorry... how time flies. I'm on it this night! :)
Expect release tomorrow, maximum 24-36h.

btw, @zeke, what you think about tunnckoCore/opensource#60. Just share some thoughts :)
It (probably) won't apply for the upcoming release anyway, I'm just collecting thoughts.

[tunnckoCore]

Okay, i've done a lot of things and wanted to release v4 release. But will go with the simple one (with just adding the ! to the regex) and a patch version to resolve these issues.

[tunnckoCore]

@zeke please use 4.0.0-alpha.12 / the next dist-tag. For now.

[zeke]

I opened PR #75 using 4.0.0-alpha.12 but some tests are failing now: https://travis-ci.org/zeke/semantic-pull-requests/builds/616072483

[zeke]

This should be auto-deployed momentarily. @binarylogic let us know how it goes!

[binarylogic]

Thank you!

[binarylogic]

@zeke we're still seeing this problem :( Is there anything we need to do to update? For example:

vectordotdev/vector#1404

[tunnckoCore]

@zeke we're still seeing this problem :( Is there anything we need to do to update? For example:

timberio/vector#1404

probably because the space in scope? try that, if not... I can't help now.

[zeke]

Looks like the check was green by the time the PR was merged: