Tests e2e Playwright : Store logs in Project POM #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follow up 3liz#5204 Add a way to store and check logs in Project page.
rldhont
added
tests
Gustry
reviewed
Jan 17, 2025
| @@ -103,6 +135,7 @@ export class ProjectPage { | |||
| */ | |||
| async open(){ | |||
| await gotoMap(`/index.php/view/map?repository=${this.repository}&project=${this.project}`, this.page); | |||
| expect(this.logs).toHaveLength(0) | |||
There was a problem hiding this comment.
This problem of this open method, it's used only 3 times, versus 107 times for the function gotoMap.
What don't we move it to a "standalone function" instead of a method of this class ? So it can be called at the end of gotoMap, while we are doing the transition.
If we want to keep it in POM, I think #5225 should be merged first, so it can be in the base class.
There was a problem hiding this comment.
It is a draft to test it. I don't know how we will have to use it.
| * @property {string} message - the log message text | ||
| * @property {string} location - the log message location in one line | ||
| * @see https://playwright.dev/docs/api/class-consolemessage | ||
| */ |
There was a problem hiding this comment.
Sorry, I'm not sure to understand the purpose of this block ?
There was a problem hiding this comment.
It is done to describe logMessage object to simplify logs property description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #5204
Add a way to store and check logs in Project page.