Fixes: refactored election solidity file and fixed election starting logic

[AdityaInnovates]

The pull request is regarding the issue: #88

1. Incorrect Modifier Logic (electionStarted)

• Issue: The electionStarted modifier is supposed to ensure the election has started, but its logic is incorrect:

  if (block.timestamp > electionInfo.startTime) revert ElectionInactive();

  • Corrected: This should check if the current time is before the start time:

    if (block.timestamp < electionInfo.startTime) revert ElectionInactive();

2. Unused Candidate ID (Candidate Struct)

• Issue: The Candidate struct includes candidateID, which is commented to be unnecessary, yet still used:

  struct Candidate {
      uint candidateID; // remove candidateId its not needed
      string name;
      string description;
  }

  • Corrected: Remove candidateID from the struct if it’s truly unnecessary. The candidates index in the the candidates array can serve as a unique identifier.

  struct Candidate {
      string name;
      string description;
  }

[Ronnieraj37]

Hey @AdityaInnovates the Modifier

modifier electionStarted() {
        if (block.timestamp > electionInfo.startTime) revert ElectionInactive();
        _;
    }

is being used in functions Add / Remove Candidate. Thus the check is to ensure that we don't remove the candidate after the election starts as this might cause multiple problems.

[AdityaInnovates]

Okay, got it, I have fixed the logic. @Ronnieraj37
The PR is ready to be merged now.