Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Popular Monuments View Mobile ✅ #220

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

kareemabdeen
Copy link
Contributor

##Describtion
This refactor simplifies and modularizes the PopularMonumentsViewMobile by extracting reusable components and improving readability. The grid view logic has been moved into a separate widget, making the codebase easier to maintain and test while keeping functionality intact.

Key Changes:

. Modularized Components:

  • Extracted the grid view logic into a dedicated PopularMonumentsGridViewWidget.
  • Made PopularMonumentsViewMobileBodyBlocBuilder more focused on managing state transitions and delegating UI logic to sub-widgets.

Motivation:

These changes aim to enhance app performance, simplify testing, and improve the maintainability of the codebase. The modular structure also promotes reusability of components across different views or contexts in the future insha2allah.


Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update

How Has This Been Tested?

Check that all refactored changes not break any changes to the current view


Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tag the PR with the appropriate labels

@kareemabdeen kareemabdeen requested a review from jddeep as a code owner December 30, 2024 16:30
@kareemabdeen
Copy link
Contributor Author

Can you please check current changes? @mdmohsin7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant