Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CI for PRs and re-enable Playwright for release #11147

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Conversation

rickyrombo
Copy link
Contributor

@rickyrombo rickyrombo commented Jan 24, 2025

  • Remove integration workflow from PRs (only run on release branches)
    • Could argue this should run on main though too, or some nightly job?
  • Add job to Setup workflow to wait and watch for any workflow failures for PRs
    • Any workflow that runs is now ~required (it can be skipped, but not fail). If you don't want something to be required on PRs, don't run it on the PR triggers. My hot take is whatever CI runs on PRs should be required to not fail. That said, we can adjust the script to a filter for specific workflows in the for loop if that's too controversial.
    • DMs on failure with ~same output as #eng-ci-notifications so you know if your automerge fails
    • Meant to become the new "required" step for PRs
  • Re-enable Playwright tests for release branch
    • Controversial, but I think it should run - flakes or not! If it reports errors, those can be checked on manually as part of release process.

Copy link

changeset-bot bot commented Jan 24, 2025

⚠️ No Changeset found

Latest commit: b9f4591

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant