Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nix): packages.${system}.ags.wrap function #665

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ys5g
Copy link
Contributor

@ys5g ys5g commented Jan 7, 2025

Motivation: overring extraPackages resulted in re-compilation of the ags go binary, which was a bit annoying.

Would it be better to implement this function in the passthru attributes of ags and agsFull?

Like(in nix/default.nix)

{
# ...
  passthru.wrapAgs = import ./wrap.nix;
# ...
}

@Aylur
Copy link
Owner

Aylur commented Jan 12, 2025

This just adds unnecessary noise imo. The purpose of agsFull is that you can start out with it without worrying about what packages you want. Then when you have a somewhat functioning shell you are happy with you can cherry pick dependencies. You won't be adding extra packages very often and go builds are fast anyway.

@ys5g
Copy link
Contributor Author

ys5g commented Jan 14, 2025

If you meant noise on the user side, putting it into passthru.wrapAgs would get rid of it. I think I should have done that from the start. I'll try getting that refactored in a day.
Imo, it doesn't seem like it is noisy on ags's side.

This PR isn't that important so, if you want to, you can close it.

@ys5g ys5g marked this pull request as draft January 15, 2025 17:00
@ys5g ys5g force-pushed the nix-wrapping-optimization branch from 3d75342 to 81abedd Compare January 15, 2025 17:37
@ys5g ys5g closed this Jan 15, 2025
@ys5g ys5g force-pushed the nix-wrapping-optimization branch from 81abedd to 251d394 Compare January 15, 2025 17:41
@ys5g ys5g reopened this Jan 15, 2025
@ys5g ys5g marked this pull request as ready for review January 15, 2025 17:56
@ys5g ys5g changed the title feat(nix): lib.wrap function feat(nix): packages.${system}.ags.wrap function Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants