Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for gcc 11.3 on Ubuntu 22 #2448

Merged
merged 1 commit into from
Dec 13, 2022
Merged

Workaround for gcc 11.3 on Ubuntu 22 #2448

merged 1 commit into from
Dec 13, 2022

Conversation

CIPop
Copy link
Member

@CIPop CIPop commented Dec 12, 2022

Fixes #2447

@CIPop CIPop requested a review from barcharcraz December 12, 2022 23:50
@CIPop CIPop enabled auto-merge (squash) December 13, 2022 01:45
ewertons
ewertons approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@ewertons ewertons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to share this with the Azure SDK team to ensure we test the code against gcc 11.3 as well as previous versions (before Ubuntu 22.04).

@CIPop CIPop merged commit 0310b2a into Azure:main Dec 13, 2022
@CIPop CIPop deleted the deprecated_fix branch December 13, 2022 17:54
@CIPop CIPop mentioned this pull request Dec 13, 2022
Open
2 tasks
@CIPop
Copy link
Member Author

CIPop commented Dec 13, 2022

Thank you @ewertons!
I am tracking the gate feature request in #2450 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewertons ewertons ewertons approved these changes

@barcharcraz barcharcraz Awaiting requested review from barcharcraz

@ahsonkhan ahsonkhan Awaiting requested review from ahsonkhan

@antkmsft antkmsft Awaiting requested review from antkmsft antkmsft is a code owner

@RickWinter RickWinter Awaiting requested review from RickWinter RickWinter is a code owner

@vhvb1989 vhvb1989 Awaiting requested review from vhvb1989

@gearama gearama Awaiting requested review from gearama gearama is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit Test Building Failing on Ubuntu 22.04
2 participants
@CIPop @ewertons