-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to skip the powershell rules #378
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnathonMohr
requested changes
Jan 7, 2025
JohnathonMohr
approved these changes
Jan 9, 2025
reynoldsa
approved these changes
Jan 9, 2025
Will try to get CodeQL to run. |
@borisf94 CodeQL appears stuck despite changing the PR status. I think it might need a new commit hash to trigger a retry. Can you try the following locally to create a new empty change? git pull
git commit --amend --no-edit
git push # maybe need to add --force-with-lease |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an ability to skip the powershell rules.
We need to be able to customize the rules that will be run using a single way to define them. The JSON rule engine provides us with all required capabilities.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines