Fix OOM error handling, Fixes AB#3124149 #2567
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Work item link check complete. Description contains link AB#3124149 to an Azure Boards work item. |
1 similar comment
|
✅ Work item link check complete. Description contains link AB#3124149 to an Azure Boards work item. |
github-actions
bot
changed the title
mohitc1
reviewed
Jan 10, 2025
| // Shut down current process | ||
| // Calling client app will receive "killed unexpectedly" error from MSAL if broker is shut down with this statement | ||
| // Calling application should not crash, and should be able to make another call, which will result in a new broker process. | ||
| System.exit(0); |
There was a problem hiding this comment.
What error/response does calling app receive in when this happens?
There was a problem hiding this comment.
There's also android.os.Process.killProcess(android.os.Process.myPid()); this might be better to use in case of OOM. I read a bit, you may also read once and we can finalize
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our error handling for the out of memory exception. Currently, we return out of memory exception like any other exception caught through our exception adapter. In the case of out of memory exception, we should shut down broker process gracefully, to allow reallocation of free memory for the broker process. Calling application will fail the request that triggered the out of memory exception and cause broker process to end. Next request by calling application will launch a new broker process.
Validation:
AB#3124149